Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bxt_collision_depth_map_fov #414

Merged
merged 3 commits into from
Feb 18, 2023

Conversation

SmileyAG
Copy link
Collaborator

No description provided.

@YaLTeR
Copy link
Owner

YaLTeR commented Feb 17, 2023

Hm, why would you want a separate cvar for this? Just change default_fov?

@SmileyAG
Copy link
Collaborator Author

SmileyAG commented Feb 17, 2023

Hm, why would you want a separate cvar for this? Just change default_fov?

  • In some modifications default_fov is not exist

  • Even if I use bxt_force_fov with hooked bxt-rs, then BXT code with getting value from bxt_force_fov would be ignored for some reason (w/o hooked bxt-rs it works, probably bxt-rs just re-register that cvar again due it have implementation of it as well or something else?)

@YaLTeR
Copy link
Owner

YaLTeR commented Feb 17, 2023

w/o hooked bxt-rs it works, probably bxt-rs just re-register that cvar again due it have implementation of it as well or something else

Yeah, that must be the reason. Hm, not sure, maybe it's possible to check in BXT when registering cvar if it's already registered, and in that case bind to the existing cvar value? Idk if that's easy to do with the current BXT code but that would be a better solution I think

@YaLTeR YaLTeR merged commit 6349d31 into YaLTeR:master Feb 18, 2023
@SmileyAG SmileyAG deleted the collision_depth_map_fov branch February 19, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants